Test Lock vs ReaderWriterLockSlim #4154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rough test switching biota property get/set to be protected by a lock vs a readerwriterlockslim. ReaderWriterLockSlim is more efficient when you have many readers vs seldom writers. WIthout contention, Lock is ~5x more performant than ReaderWriterLockSlim.EnterReadLock ACE current landblock group and threading model should result in minimal cases where multiple readers are accessing the same biota simultaneously, thus, lock may be the preferred choice.
|
For clarification, after testing on .NET 8, performance is not 5x, but maybe 0.5x |
|
Closed and Reopened because the merge status was busted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough test switching biota property get/set to be protected by a lock vs a readerwriterlockslim.
ReaderWriterLockSlim is more efficient when you have many readers vs seldom writers.
WIthout contention, Lock is ~5x more performant than ReaderWriterLockSlim.EnterReadLock
ACE current landblock group and threading model should result in minimal cases where multiple readers are accessing the same biota simultaneously, thus, lock may be the preferred choice.